Skip to content

BI-1583 Error Message 1: Missing Data Worksheet#246

Merged
davedrp merged 4 commits intodevelopfrom
feature/BI-1583
Apr 6, 2023
Merged

BI-1583 Error Message 1: Missing Data Worksheet#246
davedrp merged 4 commits intodevelopfrom
feature/BI-1583

Conversation

@davedrp
Copy link
Contributor

@davedrp davedrp commented Mar 30, 2023

Description

BI-1583

  • For Germplasm and Experiment imports,
    • add error banner message if the import XSL files does not have a workbook sheet titled "Data". (to allow for backward compatibility also all allow the sheet to be titled "Germplasm Import" or "Experiment Data")
  • For Ontology imports,
    • Improve the error message.
    • Show the error message if the import XSL files does not have a workbook sheet titled "Data". (or, for backward compatibility "Template")

Dependencies

bi-web branch feature/BI-1583

Testing

Germplasm Import

  1. Create a valid Germplasm import XSL-file, with the date in a Worksheet titled "Data"
  2. Import the file
    EXPECTED RESULT
    The validation is successful.
  3. Create a valid Germplasm import XSL-file, with the date in a Workbook sheet titled "Germplasm Import"
  4. Import the file
    EXPECTED RESULT
    The validation is successful.
  5. Create a valid Germplasm import XSL-file, with the date in a Worksheet titled "Something Else"
  6. Import the file
    EXPECTED RESULT
    Error Banner reading " Error(s) detected in file, [File Name]. Worksheet titled 'Data' is missing. Import cannot proceed. "

Ontology Import

  1. Create a valid Ontology import XSL-file, with the date in a Worksheet titled "Data"
  2. Import the file
    EXPECTED RESULT
    The validation is successful.
  3. Create a valid Ontology import XSL-file, with the date in a Workbook sheet titled "Template"
  4. Import the file
    EXPECTED RESULT
    The validation is successful.
  5. Create a valid Ontology import XSL-file, with the date in a Worksheet titled "Something Else"
  6. Import the file
    EXPECTED RESULT
    Error reading "Error(s) detected in file, [File Name]. Worksheet titled 'Data' is missing. Import cannot proceed. "

Experiments & Observations Import

  1. Create a valid Experiments & Observations import XSL-file, with the date in a Worksheet titled "Data"
  2. Import the file
    EXPECTED RESULT
    The validation is successful.
  3. Create a valid Experiments & Observations import XSL-file, with the date in a Workbook sheet titled "Experiment Data"
  4. Import the file
    EXPECTED RESULT
    The validation is successful.
  5. Create a valid Experiments & Observations import XSL-file, with the date in a Worksheet titled "Something Else"
  6. Import the file
    EXPECTED RESULT
    Error Banner reading " Error(s) detected in file, [File Name]. Worksheet titled 'Data' is missing. Import cannot proceed. "

Checklist:

  • I have performed a self-review of my own code
  • I have tested my code and ensured it meets the acceptance criteria of the story
  • I have tested that my code works with both the brapi-java-server and BreedBase
  • I have create/modified unit tests to cover this change
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to documentation
  • I have run TAF: [](https://github.com/Breeding-Insight/taf/actions/runs/4566702657)

@davedrp davedrp marked this pull request as ready for review March 30, 2023 19:44
@nickpalladino
Copy link
Member

Testing looks good

@davedrp davedrp merged commit 4ee0830 into develop Apr 6, 2023
@davedrp davedrp deleted the feature/BI-1583 branch April 6, 2023 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants