Conversation
| //arbitrary, large value to ensure that in the event that a 202 response is returned, the searchDbId | ||
| //stored will refer to all records of the BrAPI variable. | ||
| searchBody.pageSize(10000000); | ||
| searchBody.pageSize(1000); |
There was a problem hiding this comment.
I can see why 10000000 is excessively large. But is 1000 large enough? Too small of a pageSize could cause a problem, but is there a down side to a pageSize that it too large?
There was a problem hiding this comment.
@davedrp Fair question. It could be, but I think part of that would be doing some trial and error. For calls to BreedBase, we had to set this to an excessively large number due to the way in which the POST /search endpoints are implemented. For Gigwa, there's a bug where they limit the page size, but the pagination metadata in the response is still utilizing the page size sent on the request to calculate the total number of pages. Because of this, I changed the page size to 1000 for the searchWithToken method (that method is only utilized by the code interacting with Gigwa at the moment).
I updated this to use the brapi.page-size configuration that's in application.yml so that it's no longer hard coded for the searchWithToken method.
Description
Story: https://breedinginsight.atlassian.net/browse/BI-1741
Updating how calls are fetched to prevent duplication of calls when there is more than one callset per germplasm
Dependencies
bi-web bug/BI-1741
brapi bug/BI-1741
Mgdb2BrapiV2Impl bug/BI-1741
Testing
Test using instructions from BI-1650
Checklist: