[BI-1629] Add filtering to Ontology Table#243
Merged
Conversation
timparsons
requested changes
Mar 3, 2023
Member
timparsons
left a comment
There was a problem hiding this comment.
Code looks good, but had one issue when I was testing from the UI
Comment on lines
+76
to
+82
| if (!StringUtils.isBlank(getMethodDescription())) { | ||
| filters.add(constructFilterRequest("methodDescription", getMethodDescription())); | ||
| } | ||
| if (!StringUtils.isBlank(getMethodClass())) { | ||
| filters.add(constructFilterRequest("methodClass", getMethodClass())); | ||
| } |
Member
There was a problem hiding this comment.
I think these two fields need to be combined together for filtering purposes because the UI combines them together for display purposes. When I tried filtering by that column, the filter only applies to the method description.
Example UI filtering: on the UI the "Method" column shows "test Measurement". If I type in "test" as my filter, then the ontology term shows correctly, however, if I type "Measurement", the term does not show in the table.
davedrp
approved these changes
Mar 8, 2023
timparsons
approved these changes
Mar 8, 2023
aee2a1b to
4f9d159
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Story: BI-1629
TraitsQuery#constructSearchRequestwas created and called in the GET /traits controller ofTraitsController.The query params and search request are then passed to the same
ResponseUtilsmethod used by POST /traits for returning filtered traits.Dependencies
none
Testing
call
GET /traits?<field>=<value>using a searchable field for traits and verify only filtered traits returned.Checklist: