Conversation
davedrp
approved these changes
Feb 6, 2023
nickpalladino
approved these changes
Feb 8, 2023
Member
nickpalladino
left a comment
There was a problem hiding this comment.
Tested with brapi test server and breedbase. Verified pedigrees looked correct in pedigree viewer.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Story: BI-1129
The germplasm processor was only checking for a possible empty value of the male pedigree parent. A check was put in place for the female parent as well.
Dependencies
bi-web: develop
Testing
Import germplasm where one of the accessions references a male parent but has a value of 0 entered for the gid of the female parent. Download the list and verify the contents of the download are correct.
Checklist: