Skip to content

BI-1548 - Experiments: User and Creation Date Refinement#238

Merged
nickpalladino merged 1 commit intodevelopfrom
feature/BI-1548
Feb 2, 2023
Merged

BI-1548 - Experiments: User and Creation Date Refinement#238
nickpalladino merged 1 commit intodevelopfrom
feature/BI-1548

Conversation

@nickpalladino
Copy link
Member

@nickpalladino nickpalladino commented Jan 24, 2023 •
edited
Loading

Description

Story: https://breedinginsight.atlassian.net/browse/BI-1548?atlOrigin=eyJpIjoiMDU3NTE2YWExOTFlNGMxZWJlOTA2N2Y2YWRhOWY3NDYiLCJwIjoiaiJ9

  • Added createdBy and createDate experiment filtering

Dependencies

Testing

  • Test sorting and filtering for experiments CreatedBy and createDate

Checklist:

  • I have performed a self-review of my own code
  • I have tested my code and ensured it meets the acceptance criteria of the story
  • I have tested that my code works with both the brapi-java-server and BreedBase
  • I have create/modified unit tests to cover this change
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to documentation
  • I have run TAF: <please include a link to TAF run>

@nickpalladino nickpalladino requested review from a team, HMS17, dmeidlin and timparsons and removed request for a team and HMS17 January 24, 2023 19:33
@timparsons timparsons self-assigned this Jan 25, 2023
timparsons
timparsons approved these changes Jan 25, 2023
View reviewed changes
Copy link
Member

@timparsons timparsons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving assuming the build failures are corrected

@nickpalladino nickpalladino merged commit def1ce5 into develop Feb 2, 2023
@nickpalladino nickpalladino deleted the feature/BI-1548 branch February 2, 2023 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@timparsons timparsons timparsons approved these changes

@dmeidlin dmeidlin dmeidlin approved these changes

Assignees

@timparsons timparsons

Labels

feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nickpalladino @timparsons @dmeidlin