Skip to content

BI-1683 - Missing female parent in biparental cross results in dropped male parent v0.7#235

Merged
timparsons merged 3 commits intomainfrom
hotfix/BI-1683
Jan 4, 2023
Merged

BI-1683 - Missing female parent in biparental cross results in dropped male parent v0.7#235
timparsons merged 3 commits intomainfrom
hotfix/BI-1683

Conversation

@timparsons
Copy link
Member

@timparsons timparsons commented Dec 22, 2022

Description

Story: https://breedinginsight.atlassian.net/browse/BI-1683

Added a validation to check if a female parent is provided when only a male parent is provided. Also allowing only a male parent to be saved when persisting to the BrAPI server

Dependencies

SGN - Breeding-Insight/sgn#94

Testing

Germ_BI-1683.xls
The attached file has two germplasm records with only a male parent defined (and 0 for the female parent).

  • Upload a file with only a male parent defined and no female parent defined. Ensure an error is returned stating a female parent must be defined
  • Upload a file with a male parent defined, and a female parent of 0. Ensure the preview works, and then you are able to confirm the import. After import, confirm the persisted germplasm has the correct pedigree when viewing the germplasm detail page and the all germplasm table

Checklist:

  • I have performed a self-review of my own code
  • I have tested my code and ensured it meets the acceptance criteria of the story
  • I have tested that my code works with both the brapi-java-server and BreedBase - just tested with BreedBase
  • I have create/modified unit tests to cover this change
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to documentation
  • I have run TAF: <please include a link to TAF run>

@timparsons timparsons requested review from a team, HMS17 and dmeidlin and removed request for a team December 22, 2022 21:34
@timparsons timparsons requested review from davedrp and nickpalladino and removed request for HMS17 and dmeidlin December 22, 2022 21:34
@nickpalladino
Copy link
Member

testing passed

@timparsons timparsons merged commit 690d11e into main Jan 4, 2023
@timparsons timparsons deleted the hotfix/BI-1683 branch January 4, 2023 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants