BI-1683 - Missing female parent in biparental cross results in dropped male parent v0.7#235
Merged
timparsons merged 3 commits intomainfrom Jan 4, 2023
Merged
BI-1683 - Missing female parent in biparental cross results in dropped male parent v0.7#235timparsons merged 3 commits intomainfrom
timparsons merged 3 commits intomainfrom
Conversation
nickpalladino
approved these changes
Jan 3, 2023
Member
|
testing passed |
davedrp
approved these changes
Jan 4, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Story: https://breedinginsight.atlassian.net/browse/BI-1683
Added a validation to check if a female parent is provided when only a male parent is provided. Also allowing only a male parent to be saved when persisting to the BrAPI server
Dependencies
SGN - Breeding-Insight/sgn#94
Testing
Germ_BI-1683.xls
The attached file has two germplasm records with only a male parent defined (and
0for the female parent).0. Ensure the preview works, and then you are able to confirm the import. After import, confirm the persisted germplasm has the correct pedigree when viewing the germplasm detail page and the all germplasm tableChecklist: