Skip to content

BI-1665 Store observations when importing new environments#234

Merged
davedrp merged 9 commits intodevelopfrom
feature/BI-1665
Feb 2, 2023
Merged

BI-1665 Store observations when importing new environments#234
davedrp merged 9 commits intodevelopfrom
feature/BI-1665

Conversation

@davedrp
Copy link
Contributor

@davedrp davedrp commented Dec 22, 2022

Description

BI-1665

Dependencies

sgn: feture/BI-1665 branch
bi-web: develop branch

Set Up

in your sgn_local.conf add the key-value pair:
brapi_observations_require_login 0

Testing

  1. Import an Experiments & Observation file with at least one phenotype column with the corresponding timestamp column(s).
  2. Confirm the import.
  3. Insure that the data has been saved in he backing BrAPI server

Checklist:

  • I have performed a self-review of my own code
  • I have tested my code and ensured it meets the acceptance criteria of the story
  • I have tested that my code works with both the brapi-java-server and BreedBase
  • I have create/modified unit tests to cover this change
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to documentation
  • I have run TAF: <please include a link to TAF run>

@davedrp davedrp requested review from a team, HMS17 and timparsons and removed request for a team January 3, 2023 13:29
@timparsons timparsons requested review from nickpalladino and removed request for HMS17 January 4, 2023 19:12
@timparsons timparsons self-assigned this Jan 4, 2023
Copy link
Member

@timparsons timparsons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some change requests. Testing passed, but I didn't go into too many corner cases.

@davedrp davedrp merged commit 70f6980 into develop Feb 2, 2023
@davedrp davedrp deleted the feature/BI-1665 branch February 2, 2023 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants