BI-1665 Store observations when importing new environments#234
Merged
BI-1665 Store observations when importing new environments#234
Conversation
nickpalladino
approved these changes
Jan 6, 2023
timparsons
requested changes
Jan 10, 2023
Member
timparsons
left a comment
There was a problem hiding this comment.
Some change requests. Testing passed, but I didn't go into too many corner cases.
src/main/java/org/breedinginsight/brapps/importer/services/processors/ExperimentProcessor.java
Outdated
Show resolved
Hide resolved
src/main/java/org/breedinginsight/brapps/importer/services/processors/ExperimentProcessor.java
Outdated
Show resolved
Hide resolved
src/main/java/org/breedinginsight/brapps/importer/services/processors/ExperimentProcessor.java
Outdated
Show resolved
Hide resolved
276a84a to
661aea0
Compare
timparsons
approved these changes
Jan 23, 2023
661aea0 to
ecc1288
Compare
…updateObservationDbIds() method
ecc1288 to
82f4b52
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
BI-1665
Dependencies
sgn: feture/BI-1665 branch
bi-web: develop branch
Set Up
in your sgn_local.conf add the key-value pair:
brapi_observations_require_login 0Testing
Checklist: