Skip to content

[BI-1630] - De-activated programs still visible on Shared Ontology#223

Merged
HMS17 merged 2 commits intodevelopfrom
bug/BI-1630
Nov 7, 2022
Merged

[BI-1630] - De-activated programs still visible on Shared Ontology#223
HMS17 merged 2 commits intodevelopfrom
bug/BI-1630

Conversation

@HMS17
Copy link
Contributor

@HMS17 HMS17 commented Nov 4, 2022

Description

Story: BI-1630 - De-activated programs still visible on Shared Ontology

Change a getAll to getActive call in order to retrieve only active programs for sharing ontology.

Dependencies

bi-web/develop

Testing

Create programs of the same species and storage
Deactivate one program
Check that only active programs show when clicking Share Ontology under Program Management > Configuration

Checklist:

  • I have performed a self-review of my own code
  • I have tested my code and ensured it meets the acceptance criteria of the story
  • I have tested that my code works with both the brapi-java-server and BreedBase
  • I have create/modified unit tests to cover this change
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to documentation
  • I have run TAF: <please include a link to TAF run>

@github-actions github-actions bot added the bug Something isn't working label Nov 4, 2022
@HMS17 HMS17 requested review from a team, dmeidlin and timparsons and removed request for a team November 4, 2022 17:16
@HMS17 HMS17 marked this pull request as ready for review November 4, 2022 17:16
Copy link
Member

@timparsons timparsons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing passed

@HMS17 HMS17 merged commit 23ebc6f into develop Nov 7, 2022
@HMS17 HMS17 deleted the bug/BI-1630 branch November 7, 2022 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants