Skip to content

[BI-1147] 2.0 Experimental Data Preview Universal Elements#219

Merged
dmeidlin merged 2 commits intofuture/1.0from
feature/BI-1147
Oct 31, 2022
Merged

[BI-1147] 2.0 Experimental Data Preview Universal Elements#219
dmeidlin merged 2 commits intofuture/1.0from
feature/BI-1147

Conversation

@dmeidlin
Copy link
Contributor

Description

Story: BI-1147

The ExperimentProcessor was changed to pass user information when committing a new trial brapi object to the database and the ExperimentObservation model was updated to write createdBy and createdDate into additionalInfo.

Dependencies

bi-web BI-1147 branch

Testing

import an experiment and re-import experiment with different environments. Verify the preview reponse from the bi-api server contains a trial brapi object that has a createdBy object and createdDate field assigned to additinalInfo.

Checklist:

  • I have performed a self-review of my own code
  • I have tested my code and ensured it meets the acceptance criteria of the story
  • I have tested that my code works with both the brapi-java-server and BreedBase
  • I have create/modified unit tests to cover this change
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to documentation
  • I have run TAF: <please include a link to TAF run>

Copy link
Member

@timparsons timparsons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you change the target branch for this PR to develop?

@dmeidlin dmeidlin merged commit 086c412 into future/1.0 Oct 31, 2022
@dmeidlin dmeidlin deleted the feature/BI-1147 branch October 31, 2022 17:05
@dmeidlin dmeidlin restored the feature/BI-1147 branch October 31, 2022 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants