Description

Story: BI-1632 - Unknown Pedigree not displaying for BrAPI-server programs

Only valid GIDs can be stored in the backend, so in the case of Unknown or Unknown/Unknown pedigrees, what is stored in the backend for pedigree is null, with the Unknown information being stored in additionalInfo and retrieved upon display. However, BrAPIGermplasmDAO:processGermplasmForDisplay only sets pedigree values, including GERMPLASM_PEDIGREE_BY_NAME, when the pedigree stored is not null. This is not a problem in Breedbase because what is returned is always “NA/NA” so the logic to set pedigree string always triggers. For BrAPI, null was being returned in the case of pedigrees with only Unknown germplasm, so the display pedigree values were not being set.

This change removes the clause checking for non-null pedigree (as it effectively was already always true in the Breedbase case) to enable setting pedigree display values in Unknown and Unknown/Unknown cases.

Dependencies

bi-web/develop

Testing

For BB and BrAPI programs

• Import germplasm with unknown parents (both in the form of Unknown, Unknown/Unknown, and /Unknown)
• Go to All Germplasm table
• Ensure pedigrees displaying as expected in Pedigree Column
• Go to germplasm details, ensure pedigree also displaying properly there

Checklist:

• I have performed a self-review of my own code
• I have tested my code and ensured it meets the acceptance criteria of the story
• I have tested that my code works with both the brapi-java-server and BreedBase
• I have create/modified unit tests to cover this change
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to documentation
• I have run TAF: <please include a link to TAF run>