Merged
Conversation
dmeidlin
approved these changes
Oct 3, 2022
timparsons
requested changes
Oct 7, 2022
Member
timparsons
left a comment
There was a problem hiding this comment.
Very minor code change request
...eedinginsight/brapps/importer/model/imports/experimentObservation/ExperimentObservation.java
Outdated
Show resolved
Hide resolved
| } | ||
| brAPILocationDAO.createBrAPILocation(newLocations, program.getId(), upload); | ||
|
|
||
| List<BrAPILocation> createdLocations = new ArrayList<>(brAPILocationDAO.createBrAPILocation(newLocations, program.getId(), upload)); |
Member
There was a problem hiding this comment.
Not a suggestion for this card, but it may be worth having a card to refactor this logic to create a location via the ProgramLocationService, that way the location gets created in both the backing BrAPI server and in the BI DB
src/main/resources/db/migration/V1.0.3__create_obs_unit_sequence.sql
Outdated
Show resolved
Hide resolved
timparsons
approved these changes
Oct 10, 2022
…added locationDbId to new study)
…prove ProgramCahsTest.getMethodDoesNotWaitForRefresh()
Contributor
Author
|
Not merged - reopening |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
BI-1594 Fix a few Bugs in the experiment import
Dependencies
bi_web - develop branch.
Testing
NOTE: The logic for creating Observation Unit Names has changed. You may want to work in a new project to avoid naming collisions.
See Acceptance Criteria in BI-1594
Checklist: