[BI-1580] BrAPIDAOUtils pagination only fetching first page of results#215
Merged
[BI-1580] BrAPIDAOUtils pagination only fetching first page of results#215
Conversation
HMS17
requested changes
Sep 28, 2022
src/test/java/org/breedinginsight/daos/BrAPIDAOUtilUnitTest.java
Outdated
Show resolved
Hide resolved
timparsons
approved these changes
Oct 4, 2022
Member
timparsons
left a comment
There was a problem hiding this comment.
Tested the code by running the application, and pointing my databases to the QA databases. Tested viewing germplasm for the AAA-Test program, and viewing germplasm lists, and downloading a list. All passed.
I agree with Heather's comment, and am approving with the assumption that her comment will be addressed.
191f311 to
03945d0
Compare
HMS17
approved these changes
Oct 10, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Story: BI-1580
The page size used by bi-api when POSTing a search for a BrAPI variable was hard-coded to a value large enough to ensure that all records for the BrAPI variable would fit in a single page. This work-around ensures that when Breedbase returns a 202 response to the initial POST search the GET search will apply to all records of the BrAPI variable stored in Breedbase.
This change is a work-around until either Breedbase or the BrAPI spec is updated.
A unit test was created to test the search method using both the POST search callback and GET search callback.
Dependencies
none
Testing
run the unit test for BrAPIDAOUtil.search(),
src/test/java/org/breedinginsight/daos/BrAPIDAOUtilUnitTest.java,
and verify all tests pass
Checklist: