[BI-1590] - Disallow Adding New Observation Unit to Existing Environment#212
Merged
[BI-1590] - Disallow Adding New Observation Unit to Existing Environment#212
Conversation
Contributor
|
The developer test passed. |
davedrp
requested changes
Sep 23, 2022
| public class ExperimentProcessor implements Processor { | ||
|
|
||
| private static final String NAME = "Experiment"; | ||
| private static final String missingObsUnitIdError = "Experiment Units are missing Observation Unit Id.\n" + |
Contributor
There was a problem hiding this comment.
Minor quibble: By convention, because it is a static final, the variable should be in all upper case (MISSING_OBS_UNIT_ID_ERROR)
davedrp
approved these changes
Sep 27, 2022
dmeidlin
approved these changes
Sep 28, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Story: BI-1590 - Disallow Adding New Observation Unit to Existing Environment
Added logic to check for an experiment import row with an Env that already existed and no ObsUnitId (implying that a new ObsUnit should be created for an existing Environment), and if so, throw an error that displays in the banner.
In addition, fixed file mapping for experiment import template so ObsUnitId could actually be retrieved for said logic.
Note that this change just checks for existence of values in ObsUnitId column and does not do any validation on said column.
Dependencies
bi-web/develop
Testing
Checklist: