Skip to content

[BI-1574] Exp Block # not displayed#207

Merged
dmeidlin merged 2 commits intodevelopfrom
bug/BI-1574
Sep 19, 2022
Merged

[BI-1574] Exp Block # not displayed#207
dmeidlin merged 2 commits intodevelopfrom
bug/BI-1574

Conversation

@dmeidlin
Copy link
Contributor

@dmeidlin dmeidlin commented Sep 7, 2022

Description

Story: BI-1574

A typo was fixed in the BrAPIConstants class.
A REPLICATE enum in the ExperimentObservation class was replaced where BLOCK was needed, instead.

Dependencies

bi-web develop branch

Testing

import an experiment and check that the "Exp Block #" column in the preview table is the same as in the excel file.

Checklist:

  • I have performed a self-review of my own code
  • I have tested my code and ensured it meets the acceptance criteria of the story
  • I have tested that my code works with both the brapi-java-server and BreedBase
  • I have create/modified unit tests to cover this change
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to documentation
  • I have run TAF: <please include a link to TAF run>

@dmeidlin dmeidlin requested review from a team, nickpalladino and timparsons and removed request for a team September 7, 2022 21:26
@github-actions github-actions bot added the bug Something isn't working label Sep 7, 2022
Copy link
Member

@timparsons timparsons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dev testing passed

@dmeidlin dmeidlin merged commit 72ad6a6 into develop Sep 19, 2022
@dmeidlin dmeidlin deleted the bug/BI-1574 branch September 19, 2022 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants