[BI-1443] - Refactoring BrAPIDAOUtil to process pagination to fetch a…#204
Merged
timparsons merged 6 commits intodevelopfrom Aug 24, 2022
Merged
[BI-1443] - Refactoring BrAPIDAOUtil to process pagination to fetch a…#204timparsons merged 6 commits intodevelopfrom
timparsons merged 6 commits intodevelopfrom
Conversation
…ll results, and to be more testable.
67e3f61 to
e642011
Compare
HMS17
requested changes
Aug 22, 2022
| assertEquals("Germplasm A", resultTable.get(0, 1), "Incorrect data exported"); | ||
| assertEquals("2", resultTable.get(0, 6), "Incorrect data exported"); | ||
| assertEquals(2, resultTable.rowCount(), "Wrong number of rows were exported"); | ||
| // assertEquals("Germplasm A", resultTable.get(0, 1), "Incorrect data exported"); |
Contributor
There was a problem hiding this comment.
Would be ideal if possible for these assertions to be uncommented so the test checks for correct data exported and not just number of rows.
HMS17
approved these changes
Aug 23, 2022
Contributor
|
Dev-test passed |
davedrp
approved these changes
Aug 24, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Refactor BRAPIDAOUtil
BrAPIDAOUtil was refactored to enable dependency injection instead of static methods.
BrapiGermplasmServiceUnitTest was fixed and updated to use mock of refactored BrAPIDAOUtil.
Dependencies
bi-web, latest develop branch
Testing
import germplasm without error; and
run BrAPIGermplasmServiceUnitTest without error
Checklist: