Skip to content

[BI-1189] bug - Season dbId is displayed instead of year for the Env Year of existing studies.#203

Merged
davedrp merged 1 commit intodevelopfrom
bug/BI-1189
Aug 17, 2022
Merged

[BI-1189] bug - Season dbId is displayed instead of year for the Env Year of existing studies.#203
davedrp merged 1 commit intodevelopfrom
bug/BI-1189

Conversation

@davedrp
Copy link
Contributor

@davedrp davedrp commented Aug 8, 2022

Description

While testing BI-1189, a bug was discovered. If importing data for an existing study (on an existing experiment), the Env Year was displaying incorrectly in the table of the confirmation screen. It would display the Session DbId instead of the year string.

Dependencies

bi-web develop-branch

Testing

  1. Import and confirm Experiments and Observations data from a flat file.
  2. Import Experiments and Observations data from the same flat file (you should now be on the confirmation page).

Expected results
The data in the Env Year on the confirmation page's table should match the data from the flat file.

Checklist:

  • I have performed a self-review of my own code
  • I have tested my code and ensured it meets the acceptance criteria of the story
  • I have tested that my code works with both the brapi-java-server and BreedBase
  • I have create/modified unit tests to cover this change
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to documentation
  • I have run TAF: <please include a link to TAF run>

@davedrp davedrp requested review from a team, dmeidlin and timparsons and removed request for a team August 8, 2022 15:38
@github-actions github-actions bot added the bug Something isn't working label Aug 8, 2022
@davedrp davedrp requested review from HMS17 and removed request for timparsons August 8, 2022 15:47
@davedrp davedrp assigned davedrp and dmeidlin and unassigned davedrp Aug 8, 2022
@davedrp davedrp assigned HMS17 and unassigned dmeidlin Aug 10, 2022
@davedrp davedrp requested a review from HMS17 August 10, 2022 13:58
Copy link
Contributor

@HMS17 HMS17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

passed testing apart from the case where in Breedbase import fails on second import of same file, but as that is already being handled in BI-1154, passing this

@davedrp davedrp closed this Aug 16, 2022
@davedrp davedrp reopened this Aug 17, 2022
@davedrp davedrp marked this pull request as ready for review August 17, 2022 18:07
@davedrp davedrp merged commit 72808d7 into develop Aug 17, 2022
@davedrp davedrp deleted the bug/BI-1189 branch August 17, 2022 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants