Skip to content

[BI-1191] Germplasm Search#192

Merged
timparsons merged 4 commits intodevelopfrom
feature/BI-1191
Jul 13, 2022
Merged

[BI-1191] Germplasm Search#192
timparsons merged 4 commits intodevelopfrom
feature/BI-1191

Conversation

@ctucker3
Copy link
Contributor

@ctucker3 ctucker3 commented Jun 21, 2022

Description

Story: https://breedinginsight.atlassian.net/jira/software/c/projects/BI/boards/1?modal=detail&selectedIssue=BI-1191

  • Added POST search/germplasm and filters to GET /germplasm.
  • Added tests for germplasm filtering.
  • Replaced a bunch of germplasm additional info strings with constants.

Dependencies

biweb: BI-1191

Testing

  1. Upload some germplasm
  2. Try out the filters
  3. Check the debounce time, accuracy of results, multiple search behavior, how it works with pagination.

Checklist:

  • I have performed a self-review of my own code
  • I have tested my code and ensured it meets the acceptance criteria of the story
  • I have tested that my code works with both the brapi-java-server and BreedBase
  • I have create/modified unit tests to cover this change
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to documentation
  • I have run TAF: https://github.com/Breeding-Insight/taf/actions/runs/2537429563

@ctucker3 ctucker3 marked this pull request as ready for review June 21, 2022 18:22
@ctucker3 ctucker3 requested review from a team, nickpalladino and timparsons and removed request for a team June 21, 2022 18:30
@timparsons timparsons merged commit cbb1fbf into develop Jul 13, 2022
@timparsons timparsons deleted the feature/BI-1191 branch July 13, 2022 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants