[BI-1487] trait create/update: account for null method description in method name#191
Merged
ctucker3 merged 1 commit intorelease/0.6from Jun 14, 2022
Merged
[BI-1487] trait create/update: account for null method description in method name#191ctucker3 merged 1 commit intorelease/0.6from
ctucker3 merged 1 commit intorelease/0.6from
Conversation
HMS17
approved these changes
Jun 13, 2022
Contributor
HMS17
left a comment
There was a problem hiding this comment.
Works on brapi and breedbase!
timparsons
approved these changes
Jun 13, 2022
| } | ||
|
|
||
| private String constructMethodName(Trait trait, Program program) { | ||
| return !StringUtils.isBlank(trait.getMethod().getDescription()) ? |
Member
There was a problem hiding this comment.
Up to you: from a reusability perspective, the Utilities.appendProgramKey method could be used to construct the method name
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Story: https://breedinginsight.atlassian.net/jira/software/c/projects/BI/boards/1?modal=detail&selectedIssue=BI-1487
In backend, checked method description and did not add it to the method name if method description was null.
Dependencies
biweb: develop
Testing
In the brapi server and breedbase:
nullwasn't put intomethodName.nullis not put in method name.Checklist: