[BI-1446] trait error: fix error display on trait form#190
Merged
ctucker3 merged 3 commits intorelease/0.6from Jun 14, 2022
Merged
[BI-1446] trait error: fix error display on trait form#190ctucker3 merged 3 commits intorelease/0.6from
ctucker3 merged 3 commits intorelease/0.6from
Conversation
HMS17
requested changes
Jun 10, 2022
Contributor
HMS17
left a comment
There was a problem hiding this comment.
Looks like it's working locally. Have you run it against TAF? Since a decent portion of the remaining TAF failures were related to these error messages being missing.
Contributor
|
Also the wrong card is linked in the PR description. |
Contributor
Author
|
@HMS17 I ran TAF and it looks like it fixes 3 tests that were previously failing. The remaining 3 tests look to be failing because an accessor method error. |
HMS17
approved these changes
Jun 13, 2022
nickpalladino
approved these changes
Jun 14, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Story: https://breedinginsight.atlassian.net/jira/software/c/projects/BI/boards/1?modal=detail&selectedIssue=BI-1446
The trait errors were accidentally changed when making the trait file import names more consistent. (https://github.com/Breeding-Insight/bi-api/pull/150/files#diff-645879ab06ebc8d8a2f7b0272aaf4c5e897cb743c52798982139924349f1235f)
Reversed those changes for the trait form code, but kept the fixes to the trait file import code.
Dependencies
biweb: develop
Testing
Checklist: