Merged
Conversation
2e41b7b to
b2be7bd
Compare
574c32c to
d714c26
Compare
HMS17
reviewed
May 31, 2022
Contributor
HMS17
left a comment
There was a problem hiding this comment.
Had to add a breakpoint to catch the In Progress tag, but it seems to be working!
src/main/java/org/breedinginsight/brapps/importer/controllers/UploadController.java
Outdated
Show resolved
Hide resolved
HMS17
approved these changes
Jun 6, 2022
davedrp
reviewed
Jun 7, 2022
| } | ||
|
|
||
| @Override | ||
| public String getJobType() { |
Contributor
There was a problem hiding this comment.
I'm confused about the need for the JobDetail interface. I only see it implemented once (here), and then it is only used to return a hardcoded value. Is there a more direct way to code this? If not, maybe a comment would be valuable.
Member
Author
There was a problem hiding this comment.
@davedrp Added some javadoc to the JobDetail interface.
Essentially, the JobDetail interface is to allow a Job to hold additional information about a specific task, but not have to know exactly what that information is (the UI cares more about this hence why there is a getType method in the JobDetail).
davedrp
approved these changes
Jun 7, 2022
Had to bump up testcontainers to 1.15.3, and make sure the jna dependency was at 5.7.0 to support running unit test on ARM processors
ba3ce48 to
e0a8c76
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Story: https://breedinginsight.atlassian.net/browse/BI-1459
Created a new data model to represent a job, and a new endpoint to fetch all jobs for a given program.
Dependencies
bi-web: features/BI-1459
Testing
See Breeding-Insight/bi-web#232
Checklist:
I have tested that my code works with both the brapi-java-server and BreedBaseNA