Skip to content

[BI-1364] View a shared ontology that a program is subscribed to#179

Merged
dmeidlin merged 7 commits intodevelopfrom
feature/BI-1364
Jun 2, 2022
Merged

[BI-1364] View a shared ontology that a program is subscribed to#179
dmeidlin merged 7 commits intodevelopfrom
feature/BI-1364

Conversation

@dmeidlin
Copy link
Contributor

@dmeidlin dmeidlin commented Apr 15, 2022

Description

Story: BI-1364 View a shared ontology that a program is subscribed to

A new exception class for returning 400 status was created.
OntologyService methods were created that wrap around existing TraitService and TraitUploadService methods which use the program ID for the case of a non-subscriber or sharing program and the sharing program's ID in the case of a subscribed program.
TraitController and TraitUpload controller were updated to return 400 status if a subscribed program requests to create or update traits of a shared ontology.

Dependencies

bi-web BI-1364 branch

Testing

See testing procedure for biweb BI-1364.
In addition, manually try to create and update traits for a subscribing program using POST/traits, PUT/traits, PUT/trait-upload, and POST/trait-upload/.
Verify that a 400 status was returned in all cases.
NOTE: In order to manually test POST/trait-upload/ you will first need to successfully import traits via PUT/trait-upload by making two changes in TraitUploadController.java:

  1. comment out lines 76-78, and
  2. on line 73 replace ontologyService.updateTraitUpload(programId, file, actingUser); with traitUploadService.updateTraitUpload(programId, file, actingUser);.

Checklist:

  • I have performed a self-review of my own code
  • I have tested my code and ensured it meets the acceptance criteria of the story
  • I have create/modified unit tests to cover this change
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to documentation
  • I have run TAF: <link to TAF run>

@dmeidlin dmeidlin requested review from HMS17 and davedrp April 15, 2022 17:28
@dmeidlin dmeidlin changed the title Feature/bi 1364 [BI-1364] View a shared ontology that a program is subscribed to Apr 15, 2022
@davedrp
Copy link
Contributor

davedrp commented Apr 19, 2022

PASSED - happy path (as described in BI-1364.)

@timparsons timparsons force-pushed the feature/BI-1364 branch 2 times, most recently from 24eb188 to a083e88 Compare May 4, 2022 21:37
@dmeidlin dmeidlin merged commit 2384484 into develop Jun 2, 2022
@dmeidlin dmeidlin deleted the feature/BI-1364 branch June 2, 2022 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants