fix: serde-serialize can trigger package cycle detection#967
Merged
sxlijin merged 2 commits intoBoundaryML:canaryfrom Sep 18, 2024
Merged
fix: serde-serialize can trigger package cycle detection#967sxlijin merged 2 commits intoBoundaryML:canaryfrom
sxlijin merged 2 commits intoBoundaryML:canaryfrom
Conversation
|
@nicarq is attempting to deploy a commit to the Gloo Team on Vercel. A member of the Team first needs to authorize it. |
sxlijin
approved these changes
Sep 18, 2024
7465b89 to
89a8055
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm getting this error when loading the Rust project from an external source that uses wasm
I created another Rust project that uses baml and it wasn't hitting the issue, so it seems that for some reason projects that also use wasm trigger the issue.
it seems to be a very common issue
tkaitchuck/aHash#95
ranile/gloo#239
the tldr is that the feature
serde-serializerseems to be the culprit (deprecated). it's recommended to move to useserde_wasm_bindgenwhich baml already uses! so the fix seems to be just removing the feature.From my limited experience of the project and to try to make sure that the wasm build still compiles and works, i actually compiled it myself and tested it in a nodejs project, and it continues to work.
Then I imported this branch to the other project and it worked without hitting the dependency cycle issue.