Skip to content

Unable to scroll when there are many folders #3490

Merged
Rokt33r merged 1 commit intoBoostIO:masterfrom
Aaron-Bird:master
Feb 26, 2020
Merged

Unable to scroll when there are many folders #3490
Rokt33r merged 1 commit intoBoostIO:masterfrom
Aaron-Bird:master

Conversation

@Aaron-Bird
Copy link
Contributor

@Aaron-Bird Aaron-Bird commented Feb 25, 2020 •
edited
Loading

Description

Scroll bar and search bar cannot be displayed when there are many folders.

Issue fixed

#3486 Can't scroll in sidebar

before
1 1

after
1 2
When the scroll bar is hidden

4

3

Type of changes

  • 🔘 Bug fix (Change that fixed an issue)
  • ⚪ Breaking change (Change that can cause existing functionality to change)
  • ⚪ Improvement (Change that improves the code. Maybe performance or development improvement)
  • ⚪ Feature (Change that adds new functionality)
  • ⚪ Documentation change (Change that modifies documentation. Maybe typo fixes)

Checklist:

  • 🔘 My code follows the project code style
  • ⚪ I have written test for my code and it has been tested
  • ⚪ All existing tests have been passed
  • 🔘 I have attached a screenshot/video to visualize my change if possible

@Aaron-Bird Aaron-Bird changed the title [Fix bug] Unable to scroll when there are many folders Unable to scroll when there are many folders Feb 25, 2020
@ZeroX-DG ZeroX-DG added the awaiting review ❇️ Pull request is awaiting a review. label Feb 25, 2020
@Flexo013 Flexo013 mentioned this pull request Feb 25, 2020
Closed
@Flexo013
Copy link
Contributor

Flexo013 commented Feb 25, 2020

I like this a lot! Thanks a lot for the PR (and the explanatory gifs)!

ZeroX-DG
ZeroX-DG approved these changes Feb 25, 2020
View reviewed changes
Copy link
Member

@ZeroX-DG ZeroX-DG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉 the only problem that I found is the lable on hover will start to show at the wrong location once you scroll down. If you can fix it in this PR then it would be great but otherwise we can create separate PR to fix it later.
image

@ZeroX-DG ZeroX-DG added approved 👍 Pull request has been approved by sufficient reviewers. and removed awaiting review ❇️ Pull request is awaiting a review. labels Feb 25, 2020
@Rokt33r Rokt33r merged commit 71f05b9 into BoostIO:master Feb 26, 2020
@Rokt33r Rokt33r added this to the v0.15.1 milestone Feb 26, 2020
@Rokt33r Rokt33r mentioned this pull request Feb 26, 2020
Closed
This was referenced Feb 26, 2020
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ZeroX-DG ZeroX-DG ZeroX-DG approved these changes

Assignees

No one assigned

Labels

approved 👍 Pull request has been approved by sufficient reviewers.

Projects

None yet

Milestone

v0.15.1

Development

Successfully merging this pull request may close these issues.

4 participants

@Aaron-Bird @Flexo013 @ZeroX-DG @Rokt33r