Skip to content

Fixed #3287 - Fixed to work TOC links#3293

Closed
roottool wants to merge 1 commit intoBoostIO:masterfrom
roottool:fix/fix-to-work-internal-links-and-TOC-links#3287
Closed

Fixed #3287 - Fixed to work TOC links#3293
roottool wants to merge 1 commit intoBoostIO:masterfrom
roottool:fix/fix-to-work-internal-links-and-TOC-links#3287

Conversation

@roottool
Copy link
Contributor

Description

I changed scrollTo() from window to document.body.

Screenshot

fixToWorkTOCLinks

Issue fixed

#3287

Type of changes

  • 🔘 Bug fix (Change that fixed an issue)
  • ⚪ Breaking change (Change that can cause existing functionality to change)
  • ⚪ Improvement (Change that improves the code. Maybe performance or development improvement)
  • ⚪ Feature (Change that adds new functionality)
  • ⚪ Documentation change (Change that modifies documentation. Maybe typo fixes)

Checklist:

  • 🔘 My code follows the project code style
  • ⚪ I have written test for my code and it has been tested
  • 🔘 All existing tests have been passed
  • 🔘 I have attached a screenshot/video to visualize my change if possible

@Flexo013 Flexo013 added the awaiting review ❇️ Pull request is awaiting a review. label Oct 20, 2019
@ZeroX-DG
Copy link
Member

Thank you for your contribution but this PR is more complete so we'll use it instead. But thank you for this PR.
#3294

@ZeroX-DG ZeroX-DG closed this Oct 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting review ❇️ Pull request is awaiting a review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants