Fix/fix to work markdownlint#3147#3285
Merged
Rokt33r merged 3 commits intoBoostIO:masterfrom Oct 28, 2019
roottool:fix/fix-to-work-markdownlint#3147
Merged
Fix/fix to work markdownlint#3147#3285Rokt33r merged 3 commits intoBoostIO:masterfrom roottool:fix/fix-to-work-markdownlint#3147
Rokt33r merged 3 commits intoBoostIO:masterfrom
roottool:fix/fix-to-work-markdownlint#3147
Conversation
|
Can this be merged please? 😊 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I defined some script tags and a stylesheet in
lib\main.development.htmlbut I didn't define them inlib\main.production.htmlthen.So I define them in
lib\main.production.html.And I removed a single quotation of the key names.
Because other key names in
browser\components\CodeEditor.jswere not enclosed in a single quotation.Screenshot
Issue fixed
#3147
Type of changes
Checklist: