Fix #888 - Wrong word count due splitting#3226
Merged
Rokt33r merged 2 commits intoBoostIO:masterfrom Sep 2, 2019
thamara:iss-888
Merged
Fix #888 - Wrong word count due splitting#3226Rokt33r merged 2 commits intoBoostIO:masterfrom thamara:iss-888
Rokt33r merged 2 commits intoBoostIO:masterfrom
thamara:iss-888
Conversation
ZeroX-DG
approved these changes
Aug 28, 2019
Member
ZeroX-DG
left a comment
There was a problem hiding this comment.
LGTM 🎉 Congrats on your first PR being approved!
cjean-fr
suggested changes
Aug 30, 2019
| exportAsHtml={this.exportAsHtml} | ||
| exportAsPdf={this.exportAsPdf} | ||
| wordCount={note.content.split(' ').length} | ||
| wordCount={note.content.replace(/\r?\n?\s+/g, ' ').trim().split(' ').length} |
There was a problem hiding this comment.
Hello ! :)
I think it can be replaced by:
note.content.trim().split(/\r?\n?\s+/g).length
or even
note.content.trim().split(/\s+/g).length
since \s includes cariage returns and new lines
Member
There was a problem hiding this comment.
@thamara Can you change your code to the above suggestion for more concise code? Thanks.
Contributor
There was a problem hiding this comment.
Good point. I'd use the split(/s+/g).
Contributor
Author
There was a problem hiding this comment.
I'll make the suggested change. Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Word count on Note Details was incorrect computed by counting words splitted by space. In the event of one word per line, the count was incorrect:
This was fixed by converting line breaks into spaces and then splitting them for count:
Issue fixed
#888
Type of changes
Checklist: