Skip to content

[WIP]h1 padding bottom value changed#3215

Merged
Rokt33r merged 7 commits intoBoostIO:masterfrom
nmsohn:bugfix/3211
Feb 24, 2020
Merged

[WIP]h1 padding bottom value changed#3215
Rokt33r merged 7 commits intoBoostIO:masterfrom
nmsohn:bugfix/3211

Conversation

@nmsohn
Copy link
Contributor

@nmsohn nmsohn commented Aug 19, 2019 •
edited
Loading

Description

image

Update:
I made changes to all headings. Now, if you keep typing lines, some horizontal lines disappear randomly on 80% and 90% views. I am looking into other markdown css at the moment

Issue fixed

#3211

Type of changes

  • 🔘 Bug fix (Change that fixed an issue)
  • ⚪ Breaking change (Change that can cause existing functionality to change)
  • ⚪ Improvement (Change that improves the code. Maybe performance or development improvement)
  • ⚪ Feature (Change that adds new functionality)
  • ⚪ Documentation change (Change that modifies documentation. Maybe typo fixes)

Checklist:

  • 🔘 My code follows the project code style
  • ⚪ I have written test for my code and it has been tested
  • ⚪ All existing tests have been passed
  • 🔘 I have attached a screenshot/video to visualize my change if possible

@ZeroX-DG ZeroX-DG added the awaiting review ❇️ Pull request is awaiting a review. label Aug 20, 2019
ZeroX-DG
ZeroX-DG requested changes Aug 21, 2019
View reviewed changes
@ZeroX-DG ZeroX-DG added awaiting changes 🖊️ Pull request has been reviewed, but contributor needs to make changes. and removed awaiting review ❇️ Pull request is awaiting a review. labels Aug 21, 2019
ZeroX-DG
ZeroX-DG requested changes Aug 25, 2019
View reviewed changes
Copy link
Member

@ZeroX-DG ZeroX-DG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just 1 more request, can you apply the same fix for other heading tag too? h1, h2, h3 etc. Thank you for your contribution 👍

@ZeroX-DG
Copy link
Member

ZeroX-DG commented Aug 28, 2019 •
edited
Loading

@nmsohn Are you still fixing it? Or you finished it?

@nmsohn
Copy link
Contributor Author

nmsohn commented Aug 29, 2019 •
edited
Loading

@nmsohn Are you still fixing it? Or you finished it?

Hi,
I changed h1 and h2 paddings. As far as I see, I don't think there is h3. Let me know if more changes to be made:)

Update:
@ZeroX-DG Yes, you were right. Some headings still break. I am updating them all now

@ZeroX-DG
Copy link
Member

ZeroX-DG commented Aug 29, 2019

@nmsohn There're h1 -> h6. We should cover every cases in so that the bug doesn't happen again.

@nmsohn nmsohn changed the title h1 padding bottom value changed [WIP]h1 padding bottom value changed Aug 30, 2019
@Flexo013 Flexo013 added awaiting review ❇️ Pull request is awaiting a review. and removed awaiting changes 🖊️ Pull request has been reviewed, but contributor needs to make changes. labels Aug 30, 2019
ZeroX-DG
ZeroX-DG requested changes Jan 29, 2020
View reviewed changes
Copy link
Member

@ZeroX-DG ZeroX-DG left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix your code. If you think of any better solution please share with me 😃

@ZeroX-DG ZeroX-DG added awaiting changes 🖊️ Pull request has been reviewed, but contributor needs to make changes. and removed awaiting review ❇️ Pull request is awaiting a review. labels Jan 29, 2020
ZeroX-DG
ZeroX-DG approved these changes Feb 12, 2020
View reviewed changes
Copy link
Member

@ZeroX-DG ZeroX-DG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@ZeroX-DG ZeroX-DG added approved 👍 Pull request has been approved by sufficient reviewers. and removed awaiting changes 🖊️ Pull request has been reviewed, but contributor needs to make changes. labels Feb 12, 2020
@Rokt33r Rokt33r added this to the v0.15.0 milestone Feb 24, 2020
@Rokt33r Rokt33r merged commit 5edce1f into BoostIO:master Feb 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ZeroX-DG ZeroX-DG ZeroX-DG approved these changes

+1 more reviewer

@cyrus303 cyrus303 cyrus303 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved 👍 Pull request has been approved by sufficient reviewers.

Projects

None yet

Milestone

v0.15.0

Development

Successfully merging this pull request may close these issues.

5 participants

@nmsohn @ZeroX-DG @cyrus303 @Flexo013 @Rokt33r