Fix #3174: Enable dragging of notes#3195
Merged
Rokt33r merged 1 commit intoBoostIO:masterfrom Aug 24, 2019
Merged
Conversation
ZeroX-DG
approved these changes
Aug 2, 2019
Member
ZeroX-DG
left a comment
There was a problem hiding this comment.
LGTM 🎉 I didn't think of the drag n drop note feature is using the default dragging behavior. Thanks for fixing this 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
user-drag: nonestyle fromMarkdownNoteDetail.stylwas applied to everydivin the app and disabled dragging of notes.Changed styling to address only the buttons/icons to disable the dragging of them.
One point where I'm not sure - was dragging of notes to trash icon supported by a previous app version because that's not working but I'm not sure if that was available before.
Issue fixed
#3174
Type of changes
Checklist:
Screenshots
Note dragging

Disabled dragging in NoteDetailInfo bar still working

A bit difficult to show in a screenrecording but I clicked every icon in the upper right bar and tried to drag the icon. The circle on the cursor during dragging is from the screenrecorder indicating a mousedown.