Skip to content

improve autocomplete within code blocks#2594

Merged
Rokt33r merged 3 commits intoBoostIO:masterfrom
daiyam:fix-autocomplete-codeblock
Jul 20, 2020
Merged

improve autocomplete within code blocks#2594
Rokt33r merged 3 commits intoBoostIO:masterfrom
daiyam:fix-autocomplete-codeblock

Conversation

@daiyam
Copy link
Contributor

@daiyam daiyam commented Nov 10, 2018

Description

This change separates the autocomplete's configuration between generic markdown and with code blocks.
It allows to disable autocomplete on * or $ characters in code blocks.

Issue fixed

Type of changes

  • ⚪ Bug fix (Change that fixed an issue)
  • ⚪ Breaking change (Change that can cause existing functionality to change)
  • 🔘 Improvement (Change that improves the code. Maybe performance or development improvement)
  • ⚪ Feature (Change that adds new functionality)
  • ⚪ Documentation change (Change that modifies documentation. Maybe typo fixes)

Checklist:

  • 🔘 My code follows the project code style
  • ⚪ I have written test for my code and it has been tested
  • 🔘 All existing tests have been passed
  • ⚪ I have attached a screenshot/video to visualize my change if possible

@ZeroX-DG ZeroX-DG added the awaiting review ❇️ Pull request is awaiting a review. label Nov 10, 2018
@daiyam
Copy link
Contributor Author

daiyam commented Dec 27, 2018

I've added the support for the new preferences fields introduced by #2586

screenshot

@Rokt33r Rokt33r self-requested a review February 1, 2019 07:32
@Rokt33r
Copy link
Member

Rokt33r commented Feb 1, 2019

I'm going to review this in this weekend.

@ZeroX-DG
Copy link
Member

ZeroX-DG commented Jun 23, 2020

@daiyam can you resolve conflict please? 👍

@daiyam
Copy link
Contributor Author

daiyam commented Jun 26, 2020

@ZeroX-DG Here you are are ;) I've even used the newest version of of the addon closebrackets.js which adds the new option closeBefore .
You can read more about it at codemirror/codemirror5@0c5c59c

ZeroX-DG
ZeroX-DG approved these changes Jun 30, 2020
View reviewed changes
Copy link
Member

@ZeroX-DG ZeroX-DG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@ZeroX-DG ZeroX-DG added approved 👍 Pull request has been approved by sufficient reviewers. and removed awaiting review ❇️ Pull request is awaiting a review. labels Jun 30, 2020
@Rokt33r Rokt33r merged commit 1cdc74a into BoostIO:master Jul 20, 2020
@Rokt33r Rokt33r added this to the v0.16.0 milestone Jul 20, 2020
@daiyam daiyam deleted the fix-autocomplete-codeblock branch July 20, 2020 11:57
@Flexo013 Flexo013 mentioned this pull request Jul 20, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ZeroX-DG ZeroX-DG ZeroX-DG approved these changes

@Rokt33r Rokt33r Awaiting requested review from Rokt33r

Assignees

No one assigned

Labels

approved 👍 Pull request has been approved by sufficient reviewers.

Projects

None yet

Milestone

v0.16.0

Development

Successfully merging this pull request may close these issues.

3 participants

@daiyam @Rokt33r @ZeroX-DG