Skip to content

Update zh-TW.json#3537

Merged
Rokt33r merged 1 commit intoBoostIO:masterfrom
xatier:patch-1
Apr 9, 2020
Merged

Update zh-TW.json#3537
Rokt33r merged 1 commit intoBoostIO:masterfrom
xatier:patch-1

Conversation

@xatier
Copy link
Contributor

@xatier xatier commented Apr 1, 2020

Description

Issue fixed

Type of changes

  • ⚪ Bug fix (Change that fixed an issue)
  • ⚪ Breaking change (Change that can cause existing functionality to change)
  • ⚪ Improvement (Change that improves the code. Maybe performance or development improvement)
  • ⚪ Feature (Change that adds new functionality)
  • ⚫ Documentation change (Change that modifies documentation. Maybe typo fixes)

Checklist:

  • ⚪ My code follows the project code style
  • ⚪ I have written test for my code and it has been tested
  • ⚪ All existing tests have been passed
  • ⚪ I have attached a screenshot/video to visualize my change if possible
  • ⚫ This PR will modify the UI or affects the UX
  • ⚪ This PR will add/update/delete a keybinding

@xatier
Copy link
Contributor Author

xatier commented Apr 1, 2020

@opw0011 @PeterDaveHello would you like to help review my changes?

PeterDaveHello
PeterDaveHello reviewed Apr 1, 2020
View reviewed changes
PeterDaveHello
PeterDaveHello reviewed Apr 1, 2020
View reviewed changes
PeterDaveHello
PeterDaveHello reviewed Apr 1, 2020
View reviewed changes
PeterDaveHello
PeterDaveHello reviewed Apr 1, 2020
View reviewed changes
locales/zh-TW.json
"Spellcheck disabled": "拼寫檢查已關閉",
"Save tags of a note in alphabetical order": "依照字母排序儲存標籤",
"Enable live count of notes": "啟用即時統計筆記數量",
"Enable smart table editor": "啟用智能表格編輯器",
Copy link
Contributor

@PeterDaveHello PeterDaveHello Apr 1, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Due to the changes of context, I believe that this one should also be revised.

Copy link
Contributor Author

@xatier xatier Apr 1, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any suggestions?

Copy link
Contributor

@PeterDaveHello PeterDaveHello Apr 7, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At least the term of smart should be revised?

Copy link
Contributor Author

@xatier xatier Apr 8, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have strong opinions here, from the code it appears to enable the editor activity handler. I'm not exactly sure how "smart" it is, but would like to stay with the original if we don't have other better alternatives.

https://github.com/BoostIO/Boostnote/blob/0d797ce8a86c2701bda332c97af34e7fd0d1bb07/browser/main/modals/PreferencesModal/UiTab.js#L817
https://github.com/BoostIO/Boostnote/blob/592aca1539166bb9a6d1eaf36a20203fff584c37/browser/components/CodeEditor.js#L491

Copy link
Contributor

@PeterDaveHello PeterDaveHello Apr 9, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think "智能" should be "智慧"

Copy link
Contributor Author

@xatier xatier Apr 9, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uh, you were a bit too late, this commit has been merged. You may submit another PR for such change.

PeterDaveHello
PeterDaveHello reviewed Apr 1, 2020
View reviewed changes
PeterDaveHello
PeterDaveHello reviewed Apr 1, 2020
View reviewed changes
@ZeroX-DG ZeroX-DG added awaiting changes 🖊️ Pull request has been reviewed, but contributor needs to make changes. awaiting review ❇️ Pull request is awaiting a review. and removed awaiting changes 🖊️ Pull request has been reviewed, but contributor needs to make changes. labels Apr 1, 2020
Brli
Brli reviewed Apr 1, 2020
View reviewed changes
Brli
Brli reviewed Apr 1, 2020
View reviewed changes
Brli
Brli reviewed Apr 1, 2020
View reviewed changes
Brli
Brli reviewed Apr 1, 2020
View reviewed changes
Brli
Brli reviewed Apr 1, 2020
View reviewed changes
Brli
Brli reviewed Apr 1, 2020
View reviewed changes
Brli
Brli reviewed Apr 1, 2020
View reviewed changes
Brli
Brli reviewed Apr 1, 2020
View reviewed changes
Brli
Brli reviewed Apr 1, 2020
View reviewed changes
@xatier
Copy link
Contributor Author

xatier commented Apr 5, 2020

I've fixed most of the suggestions above.

@PeterDaveHello
Copy link
Contributor

PeterDaveHello commented Apr 7, 2020

Maybe also squash the commits after final fixes?

ZeroX-DG
ZeroX-DG approved these changes Apr 9, 2020
View reviewed changes
Copy link
Member

@ZeroX-DG ZeroX-DG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seem ok, I'll approve it

@ZeroX-DG ZeroX-DG added approved 👍 Pull request has been approved by sufficient reviewers. and removed awaiting review ❇️ Pull request is awaiting a review. labels Apr 9, 2020
@Rokt33r Rokt33r merged commit 433ee9e into BoostIO:master Apr 9, 2020
@Rokt33r Rokt33r added this to the v0.15.3 milestone Apr 9, 2020
@xatier xatier deleted the patch-1 branch April 9, 2020 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ZeroX-DG ZeroX-DG ZeroX-DG approved these changes

+2 more reviewers

@PeterDaveHello PeterDaveHello PeterDaveHello left review comments

@Brli Brli Brli approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved 👍 Pull request has been approved by sufficient reviewers.

Projects

None yet

Milestone

v0.15.3

Development

Successfully merging this pull request may close these issues.

5 participants

@xatier @PeterDaveHello @Brli @ZeroX-DG @Rokt33r