Add tag link handling with :tag:#tag syntax#3002
Conversation
|
@ZeroX-DG sure, I've resolved the conflict and checked the feature. I'll open an issue (if it's not already in the issues) for the Crtl+Link click that's not working for tag and line links as mentioned in my note above. Update: {
"editor.tabSize": 2,
"search.exclude": {
"**/node_modules": true
},
"typescript.validate.enable": false,
"javascript.validate.enable": false,
"[javascript]": {
"editor.formatOnSave": true
},
"editor.codeActionsOnSave": {
// For ESLint
"source.fixAll.eslint": true,
},
"git.ignoreLimitWarning": true
} |
|
That could be a good idea. Keep the consistency with other type of links like |
|
I would keep it with the hash as it's easier to remember and I think it would be confusing to users. As the tag is always displayed with the # in front. Maybe if there would be a context menu to add tag links we could do it with-out #. But we should create an issue for this and discuss it there e.g. right click on tag shows |
|
I think prefixing
Sounds good to me but should be better to presented in a separated PR. |
|
@Rokt33r sure. I've fixed it. 👍 For the context menu I'll create an issue and start working on it later today. |
Description
I've added the tag links by using
:tag:#taglink syntax.It's working but not ready for merge because I'd like to wait for React upgrade because I'm using hashHistory directly. This will be changed later to
dispatch(push(...))Issue fixed
#1683
Type of changes
Checklist:
Note
The tag links are not handled in editor just in
MarkdownPreviewand I think we should open a new issue for this as I think the other link types (:line) are also not handled - or is line & tag handling only required in preview? I think they should be handled as there is a tooltip indicating how to click but the click is not working.