new feature: filter tags and folder list#2779
Closed
elfman wants to merge 3 commits intoBoostIO:masterfrom
Closed
Conversation
ZeroX-DG
requested changes
Jan 11, 2019
Member
ZeroX-DG
left a comment
There was a problem hiding this comment.
It works great, but some adjustment is still needed. Please update your code.
| overflow hidden | ||
| transition max-height .4s | ||
| margin -5px 10px 0 | ||
| .search-input |
Member
There was a problem hiding this comment.
Can you change the background of the input according to the theme? For example, in Monokai theme here is the background of the search input:
The background of other inputs:
| display flex | ||
| text-align center | ||
|
|
||
| .extra-buttons |
Member
There was a problem hiding this comment.
The position doesn't feel right to me.
browser/main/SideNav/index.js
Outdated
| <input | ||
| styleName='search-input' | ||
| type='text' | ||
| ref={dom => { this.searchInput = dom }} |
Member
There was a problem hiding this comment.
I don't see where this ref is used. Please remove it if you don't use it. 😃
Member
|
@elfman ping |
Contributor
Author
|
@ZeroX-DG updated, please review again. Sorry, I'm too busy these days, and almost forgot this pr |
Contributor
|
Closing this as #2964 is merged and has the same function. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
for #2027
new feature: Filter tags and folder list
Type of changes
Checklist: