-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Description
Current behavior
When a note with attachment saved on a storage with path containing non-English letter (e.g. test_chinese with Path D:\測試 as follows), clicking on the link of this note does not open the attachment (like what happened in #2003).
EDIT: Here is an animation illustrating it.
Currently the best solution is right click > Show in explorer, and open that manually in explorer.
Expected behavior
Attachment should be able to open on storage with path containing non-English letter.
Steps to reproduce
- Create a storage with path containing non-English letter
(I only confirmed Chinese letter without trying other language) - Create a folder in that storage and add a note
- Add an attachment into the note
- Click on the link, the attachment fails to open, without error message.
Environment
- Version : 0.13.0
- OS Version and name : Windows 10
Diagnosis
When doing right click -> copy url, it will copy something like file:///D:/%E6%B8%AC%E8%A9%A6/attachments/f1acb39f-c175-474c-9a68-fb5523d0d3dd/61b30404.pdf, this cannot be opened by windows explorer. The url should be file:///D:/測試/attachments/f1acb39f-c175-474c-9a68-fb5523d0d3dd/61b30404.pdf instead.
This should be not difficult to solve. I can try to make a PR to fix this.
