Fix: Update h3 imports to work with h3 v4.1.0+#58
Merged
Bondify merged 1 commit intoBondify:masterfrom Jan 27, 2025
Merged
Conversation
Replaced references to the two imported functions: * geo_to_h3 -> latlng_to_cell * k_ring -> grid_ring Addresses #100
|
I hate to bother anyone for not keeping a fun side-project perfectly-up-to-date with the latest dependency changes, as I have a graveyard of such things. In fact, I'm getting back to one now that uses this library, so I hope @Bondify @Rikuoja don't mind if I bump this PR for them. 😄 It's a super small, 3-line change to the names of some function calls, if that helps! |
Owner
|
This update is due. Thanks @teleksterling for the PR and @fedderw for the reminder. I'm not giving this project as much love as I'd like lately 🙏 |
I just came back today and saw it got merged - thank you! (And totally understand) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaced references to the two functions imported from h3:
Addresses #54.
See also original comment by @dfellis in uber/h3-py#100 (comment)