build: remove wheel from list of build dependencies#23
Merged
bdraco merged 1 commit intoBluetooth-Devices:mainfrom Aug 5, 2023
tjni:build-dependency-tweaks
Merged
build: remove wheel from list of build dependencies#23bdraco merged 1 commit intoBluetooth-Devices:mainfrom tjni:build-dependency-tweaks
bdraco merged 1 commit intoBluetooth-Devices:mainfrom
tjni:build-dependency-tweaks
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #23 +/- ##
=======================================
Coverage 99.42% 99.42%
=======================================
Files 3 3
Lines 175 175
Branches 25 25
=======================================
Hits 174 174
Misses 1 1
☔ View full report in Codecov by Sentry. |
bdraco
approved these changes
Aug 5, 2023
Member
|
The cython build is preferred but not required. Its much much slower without it |
Member
|
If you are packaging its best to set in the env: REQUIRE_CYTHON=1 when building to make sure it fails if it can't cythonize |
Contributor
Author
|
Thank you very much, I'll do that! |
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It doesn't look like this is used.
A separate question: is the Cython version intended to be the preferred one (or only one) moving forward? I'm doing some work on this package in nixpkgs and wondering which one to build. Since it is listed as a build dependency in pyproject.toml, does it mean it's preferred?