App breaks when opening help#24
App breaks when opening help#24alxnull merged 5 commits intoBluegrams:masterfrom minna-xD:fix/helpform
Conversation
|
@minna-xD Great catch, I didn't notice that! 👍 There might be another case to consider for the solution: If Would be great if you could try to implement this as well (in case you want to play around with C# a little more 😃). I can help if you need any further guidance. |
|
Sure, I'll give it a go! I was originally thinking about checking if a help file exists and then falling back to English if not, so I'll try that. |
|
I made a new commit yesterday (letting you know in case there's no automatic notification) |
alxnull
left a comment
There was a problem hiding this comment.
Awesome! Looks good to me, just one comment below.
alxnull
left a comment
There was a problem hiding this comment.
Perfect, thanks again for your help! 😃
I happened to notice the help didn't open anymore (for any language) after your latest change to remove SupportedCultures. HelpForm still references the attribute.
Here's my super simple fix if it's acceptable. (I'm a complete c# newbie, my husband helped me fix it based on my solution idea :) )