Skip to content

App breaks when opening help#24

Merged
alxnull merged 5 commits intoBluegrams:masterfrom
minna-xD:fix/helpform
Oct 16, 2020
Merged

App breaks when opening help#24
alxnull merged 5 commits intoBluegrams:masterfrom
minna-xD:fix/helpform

Conversation

@minna-xD
Copy link
Contributor

I happened to notice the help didn't open anymore (for any language) after your latest change to remove SupportedCultures. HelpForm still references the attribute.

Here's my super simple fix if it's acceptable. (I'm a complete c# newbie, my husband helped me fix it based on my solution idea :) )

@alxnull
Copy link
Member

alxnull commented Oct 11, 2020

@minna-xD Great catch, I didn't notice that! 👍

There might be another case to consider for the solution: If CurrentUICulture is set to a language not supported by the app (which can happen), we need a fallback to English (similar to the rest of the UI). The simplest options could be to either check if a file Help.<lang-code>.html exists in the Help folder or if the current Culture is part of AppInfo.GetSupportedCultures() (which doesn't depend on the removed attribute). If that's not the case, we would load the English help file.

Would be great if you could try to implement this as well (in case you want to play around with C# a little more 😃). I can help if you need any further guidance.

@minna-xD
Copy link
Contributor Author

Sure, I'll give it a go! I was originally thinking about checking if a help file exists and then falling back to English if not, so I'll try that.

@minna-xD
Copy link
Contributor Author

I made a new commit yesterday (letting you know in case there's no automatic notification)

Copy link
Member

@alxnull alxnull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Looks good to me, just one comment below.

@alxnull alxnull self-requested a review October 16, 2020 17:54
Copy link
Member

@alxnull alxnull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thanks again for your help! 😃

@alxnull alxnull merged commit 988fcc5 into Bluegrams:master Oct 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

2 participants