neuron: coreneuron only supports nmodl by alkino · Pull Request #2015 · BlueBrain/spack

alkino · 2023-05-24T08:16:36Z

neuron: in Remove support of mod2c neuronsimulator/nrn#2247 CoreNEURON dropped support for mod2c
- This means that neuron@develop +coreneuron always uses nmodl
- Variants have been made conditional so that meaningless things like neuron@develop +coreneuron~nmodl are not allowed

github-actions · 2023-05-24T08:17:29Z

There are one or more issues with the title of this PR.
There are one or more issues with the commit message of commit 2b0b577.
Commit message:

Build by default with nmodl

Please satisfy at least one of the checks (one package, docs, or deploy).
The PR title must be compliant. The commit message of your commit must be compliant as well.
Issues:

The following packages were changed but not mentioned:
sim-model, neuron:
You can simply use the above list, then explain what you changed.
Alternatively, you can use one line per package to describe the change per package.
Please mention at least one package.
Deploy files were changed but not mentioned.
Please use the deploy: prefix to explain this change.
The following packages were changed but not mentioned:
sim-model, neuron:
You can simply use the above list, then explain what you changed.
Alternatively, you can use one line per package to describe the change per package.
Please mention at least one package.
Deploy files were changed but not mentioned.
Please use the deploy: prefix to explain this change.

bbpbuildbot · 2023-05-24T08:18:20Z

Thank you for your pull request!

Should you want to clear the PR build directory after failures, please use this pipeline. Before running the cleanup pipeline, please ensure that any PR building pipelines have been cancelled or finished running.

github-actions · 2023-05-24T08:23:58Z

There are one or more issues with the commit message of commit 2b0b577.
Commit message:

Build by default with nmodl

Please satisfy at least one of the checks (one package, docs, or deploy).
The PR title must be compliant. The commit message of your commit must be compliant as well.
Issues:

The following packages were changed but not mentioned:
sim-model, neuron:
You can simply use the above list, then explain what you changed.
Alternatively, you can use one line per package to describe the change per package.
Please mention at least one package.
Deploy files were changed but not mentioned.
Please use the deploy: prefix to explain this change.

bbpbuildbot · 2023-05-24T10:36:03Z

The following build jobs of the deployment for this PR failed:

applications / hpc

Please fix the following packages that failed to build:

bbpbuildbot · 2023-05-24T10:57:18Z

The following build jobs of the deployment for this PR failed:

applications / hpc

Please fix the following packages that failed to build:

bbpbuildbot · 2023-05-25T08:22:49Z

The following build jobs of the deployment for this PR failed:

applications / hpc

Please fix the following packages that failed to build:

bbpbuildbot · 2023-05-25T09:16:06Z

The following build jobs of the deployment for this PR failed:

applications / hpc

olupton

I think there are still some wrinkles to iron out.
Alternatively, if it would simplify things, we could leave the nmodl variant in and just emit an error if someone tries to build @develop ~nmodl etc.

bbpbuildbot · 2023-05-25T10:26:52Z

The following build jobs of the deployment for this PR failed:

applications / hpc

bbpbuildbot · 2023-05-25T10:46:18Z

The following build jobs of the deployment for this PR failed:

applications / hpc

bbpbuildbot · 2023-05-25T14:28:36Z

To test your PR, use the following on BlueBrain5:

unset MODULEPATH
. /gpfs/bbp.cscs.ch/ssd/apps/bsd/pulls/2015/config/modules.sh
module load unstable

Please test the following updated modules:

brainbuilder/0.18.5
connectome-tools/0.6.2
neurodamus-hippocampus/1.8-2.15.0-2.7.0
neurodamus-mousify/1.6-2.15.0-2.7.0
neurodamus-neocortex-multiscale/1.11-2.15.0-2.7.0
neurodamus-neocortex-plasticity/1.11-2.15.0-2.7.0
neurodamus-neocortex/1.11-2.15.0-2.7.0
neurodamus-thalamus/1.6-2.15.0-2.7.0
neuron/9.0.a6
placement-algorithm/2.3.0
psp-validation/0.5.0
py-archngv/3.0.0
py-bbp-analysis-framework/1.6.42
py-bbp-workflow/3.1.19
py-bglibpy/4.10.1
py-bluepy/2.5.1
py-bluepyemodel/0.0.11
py-bluepymm/0.7.65
py-bluepyopt/1.13.86
py-bluepysnap/1.0.5
py-connectome-manipulator/0.0.4
py-currentscape/0.0.10
py-minis-validation/0.0.5
py-morph-tool/2.9.0
py-morphology-repair-workflow/2.0.3
py-region-grower/0.4.3
py-sonata-network-reduction/0.1.8

bbpbuildbot · 2023-05-25T16:02:02Z

To test your PR, use the following on BlueBrain5:

unset MODULEPATH
. /gpfs/bbp.cscs.ch/ssd/apps/bsd/pulls/2015/config/modules.sh
module load unstable

Please test the following updated modules:

brainbuilder/0.18.5
connectome-tools/0.6.2
neurodamus-hippocampus/1.8-2.15.0-2.7.0
neurodamus-mousify/1.6-2.15.0-2.7.0
neurodamus-neocortex-multiscale/1.11-2.15.0-2.7.0
neurodamus-neocortex-plasticity/1.11-2.15.0-2.7.0
neurodamus-neocortex/1.11-2.15.0-2.7.0
neurodamus-thalamus/1.6-2.15.0-2.7.0
neuron/9.0.a6
placement-algorithm/2.3.0
psp-validation/0.5.0
py-archngv/3.0.0
py-bbp-analysis-framework/1.6.42
py-bbp-workflow/3.1.19
py-bglibpy/4.10.1
py-bluepy/2.5.1
py-bluepyemodel/0.0.11
py-bluepymm/0.7.65
py-bluepyopt/1.13.86
py-bluepysnap/1.0.5
py-connectome-manipulator/0.0.4
py-currentscape/0.0.10
py-minis-validation/0.0.5
py-morph-tool/2.9.0
py-morphology-repair-workflow/2.0.3
py-region-grower/0.4.3
py-sonata-network-reduction/0.1.8

bbpbuildbot · 2023-05-25T22:13:16Z

To test your PR, use the following on BlueBrain5:

unset MODULEPATH
. /gpfs/bbp.cscs.ch/ssd/apps/bsd/pulls/2015/config/modules.sh
module load unstable

Please test the following updated modules:

brainbuilder/0.18.5
connectome-tools/0.6.2
neurodamus-hippocampus/1.8-2.15.0-2.7.0
neurodamus-mousify/1.6-2.15.0-2.7.0
neurodamus-neocortex-multiscale/1.11-2.15.0-2.7.0
neurodamus-neocortex-plasticity/1.11-2.15.0-2.7.0
neurodamus-neocortex/1.11-2.15.0-2.7.0
neurodamus-thalamus/1.6-2.15.0-2.7.0
neuron/9.0.a6
placement-algorithm/2.3.0
psp-validation/0.5.0
py-archngv/3.0.0
py-bbp-analysis-framework/1.6.42
py-bbp-workflow/3.1.19
py-bglibpy/4.10.1
py-bluepy/2.5.1
py-bluepyemodel/0.0.11
py-bluepymm/0.7.65
py-bluepyopt/1.13.86
py-bluepysnap/1.0.5
py-connectome-manipulator/0.0.4
py-currentscape/0.0.10
py-minis-validation/0.0.5
py-morph-tool/2.9.0
py-morphology-repair-workflow/2.0.3
py-region-grower/0.4.3
py-sonata-network-reduction/0.1.8

bbpbuildbot · 2023-05-26T09:00:34Z

To test your PR, use the following on BlueBrain5:

unset MODULEPATH
. /gpfs/bbp.cscs.ch/ssd/apps/bsd/pulls/2015/config/modules.sh
module load unstable

Please test the following updated modules:

brainbuilder/0.18.5
connectome-tools/0.6.2
neurodamus-hippocampus/1.8-2.15.0-2.7.0
neurodamus-mousify/1.6-2.15.0-2.7.0
neurodamus-neocortex-multiscale/1.11-2.15.0-2.7.0
neurodamus-neocortex-plasticity/1.11-2.15.0-2.7.0
neurodamus-neocortex/1.11-2.15.0-2.7.0
neurodamus-thalamus/1.6-2.15.0-2.7.0
neuron/9.0.a6
placement-algorithm/2.3.0
psp-validation/0.5.0
py-archngv/3.0.0
py-bbp-analysis-framework/1.6.42
py-bbp-workflow/3.1.19
py-bglibpy/4.10.1
py-bluepy/2.5.1
py-bluepyemodel/0.0.11
py-bluepymm/0.7.65
py-bluepyopt/1.13.86
py-bluepysnap/1.0.5
py-connectome-manipulator/0.0.4
py-currentscape/0.0.10
py-minis-validation/0.0.5
py-morph-tool/2.9.0
py-morphology-repair-workflow/2.0.3
py-region-grower/0.4.3
py-sonata-network-reduction/0.1.8

bbpbuildbot · 2023-05-26T13:06:35Z

To test your PR, use the following on BlueBrain5:

unset MODULEPATH
. /gpfs/bbp.cscs.ch/ssd/apps/bsd/pulls/2015/config/modules.sh
module load unstable

Please test the following updated modules:

brainbuilder/0.18.5
connectome-tools/0.6.2
neurodamus-hippocampus/1.8-2.15.0-2.7.0
neurodamus-mousify/1.6-2.15.0-2.7.0
neurodamus-neocortex-multiscale/1.11-2.15.0-2.7.0
neurodamus-neocortex-plasticity/1.11-2.15.0-2.7.0
neurodamus-neocortex/1.11-2.15.0-2.7.0
neurodamus-thalamus/1.6-2.15.0-2.7.0
neuron/9.0.a6
placement-algorithm/2.3.0
psp-validation/0.5.0
py-archngv/3.0.0
py-bbp-analysis-framework/1.6.42
py-bbp-workflow/3.1.19
py-bglibpy/4.10.1
py-bluepy/2.5.1
py-bluepyemodel/0.0.11
py-bluepymm/0.7.65
py-bluepyopt/1.13.86
py-bluepysnap/1.0.5
py-connectome-manipulator/0.0.4
py-currentscape/0.0.10
py-minis-validation/0.0.5
py-morph-tool/2.9.0
py-morphology-repair-workflow/2.0.3
py-region-grower/0.4.3
py-sonata-network-reduction/0.1.8

alexsavulescu

LGTM

bbpbuildbot · 2023-05-26T13:34:18Z

To test your PR, use the following on BlueBrain5:

unset MODULEPATH
. /gpfs/bbp.cscs.ch/ssd/apps/bsd/pulls/2015/config/modules.sh
module load unstable

Please test the following updated modules:

brainbuilder/0.18.5
connectome-tools/0.6.2
neurodamus-hippocampus/1.8-2.15.0-2.7.0
neurodamus-mousify/1.6-2.15.0-2.7.0
neurodamus-neocortex-multiscale/1.11-2.15.0-2.7.0
neurodamus-neocortex-plasticity/1.11-2.15.0-2.7.0
neurodamus-neocortex/1.11-2.15.0-2.7.0
neurodamus-thalamus/1.6-2.15.0-2.7.0
neuron/9.0.a6
placement-algorithm/2.3.0
psp-validation/0.5.0
py-archngv/3.0.0
py-bbp-analysis-framework/1.6.42
py-bbp-workflow/3.1.19
py-bglibpy/4.10.1
py-bluepy/2.5.1
py-bluepyemodel/0.0.11
py-bluepymm/0.7.65
py-bluepyopt/1.13.86
py-bluepysnap/1.0.5
py-connectome-manipulator/0.0.4
py-currentscape/0.0.10
py-minis-validation/0.0.5
py-morph-tool/2.9.0
py-morphology-repair-workflow/2.0.3
py-region-grower/0.4.3
py-sonata-network-reduction/0.1.8

bbpbuildbot · 2023-05-30T13:43:10Z

To test your PR, use the following on BlueBrain5:

unset MODULEPATH
. /gpfs/bbp.cscs.ch/ssd/apps/bsd/pulls/2015/config/modules.sh
module load unstable

Please test the following updated modules:

brainbuilder/0.18.5
connectome-tools/0.6.2
neurodamus-hippocampus/1.8-2.15.0-2.7.0
neurodamus-mousify/1.6-2.15.0-2.7.0
neurodamus-neocortex-multiscale/1.11-2.15.0-2.7.0
neurodamus-neocortex-plasticity/1.11-2.15.0-2.7.0
neurodamus-neocortex/1.11-2.15.0-2.7.0
neurodamus-thalamus/1.6-2.15.0-2.7.0
neuron/9.0.a6
placement-algorithm/2.3.0
psp-validation/0.5.0
py-archngv/3.0.0
py-bbp-analysis-framework/1.6.42
py-bbp-workflow/3.1.19
py-bglibpy/4.10.1
py-bluepy/2.5.1
py-bluepyemodel/0.0.11
py-bluepymm/0.7.65
py-bluepyopt/1.13.86
py-bluepysnap/1.0.5
py-connectome-manipulator/0.0.4
py-currentscape/0.0.10
py-minis-validation/0.0.5
py-morph-tool/2.9.0
py-morphology-repair-workflow/2.0.3
py-region-grower/0.4.3
py-sonata-network-reduction/0.1.8

alkino changed the title ~~Build by default with nmodl~~ neuron: build by default with nmodl May 24, 2023

alkino force-pushed the cornu/only_nmodl branch from 2b0b577 to 5147325 Compare May 24, 2023 08:31

alkino closed this May 24, 2023

alkino reopened this May 24, 2023

alkino closed this May 25, 2023

alkino reopened this May 25, 2023

olupton reviewed May 25, 2023

View reviewed changes

Comment thread bluebrain/repo-patches/packages/neuron/package.py Outdated

Comment thread bluebrain/repo-patches/packages/neuron/package.py Outdated

Comment thread bluebrain/repo-patches/packages/neuron/package.py Outdated

alkino closed this May 25, 2023

alkino reopened this May 25, 2023

This was referenced May 25, 2023

neuron: bye mod2c #1997

Closed

Remove support of mod2c neuronsimulator/nrn#2247

Merged

alkino and others added 8 commits May 25, 2023 21:50

neuron: build by default with nmodl

aaa4292

Blindly fix version

e5ad8d7

can still be built with or without coreneuron

54454e5

Get nrnivmodl-core from neuron

cbb2a46

Clean conflicts

1cd1a04

Format

22c733a

Format

6fbab6a

neuron: handle nmodl-specific variants more explicitly

4ee75c4

olupton force-pushed the cornu/only_nmodl branch from cba470f to 4ee75c4 Compare May 25, 2023 19:55

fixups

7072553

olupton closed this May 26, 2023

olupton reopened this May 26, 2023

limit size of comments

0ab9c91

fixup

cd91df5

olupton force-pushed the cornu/only_nmodl branch from 5ec1ef8 to cd91df5 Compare May 26, 2023 09:13

alexsavulescu previously approved these changes May 26, 2023

View reviewed changes

alexsavulescu reviewed May 26, 2023

View reviewed changes

Comment thread bluebrain/deployment/gitlab-ci.yml Outdated

Merge branch 'develop' into cornu/only_nmodl

4eb10e5

olupton dismissed alexsavulescu’s stale review via 4eb10e5 May 30, 2023 09:54

Drop reference to cornu/remove_mod2c neuron branch

b3db6f7

olupton changed the title ~~neuron: build by default with nmodl~~ neuron: coreneuron only supports nmodl May 30, 2023

olupton approved these changes May 30, 2023

View reviewed changes

alexsavulescu enabled auto-merge (squash) May 30, 2023 12:24

alexsavulescu merged commit 04a4e95 into develop May 30, 2023

alexsavulescu deleted the cornu/only_nmodl branch May 30, 2023 13:43

olupton mentioned this pull request May 31, 2023

CoreNEURON uses NMODL, which needs sympy and a newer bison neuronsimulator/nrn-build-ci#60

Merged

Uh oh!

Conversation

alkino commented May 24, 2023 • edited by olupton Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented May 24, 2023

Uh oh!

bbpbuildbot commented May 24, 2023

Uh oh!

github-actions Bot commented May 24, 2023

Uh oh!

bbpbuildbot commented May 24, 2023

Uh oh!

bbpbuildbot commented May 24, 2023

Uh oh!

bbpbuildbot commented May 25, 2023

Uh oh!

bbpbuildbot commented May 25, 2023

Uh oh!

olupton left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bbpbuildbot commented May 25, 2023

Uh oh!

bbpbuildbot commented May 25, 2023

Uh oh!

bbpbuildbot commented May 25, 2023

Uh oh!

bbpbuildbot commented May 25, 2023

Uh oh!

bbpbuildbot commented May 25, 2023

Uh oh!

bbpbuildbot commented May 26, 2023

Uh oh!

bbpbuildbot commented May 26, 2023

Uh oh!

alexsavulescu left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

bbpbuildbot commented May 26, 2023

Uh oh!

bbpbuildbot commented May 30, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

alkino commented May 24, 2023 •

edited by olupton

Loading