Replace VERBATIM blocks for RNGs with new RANDOM constructs#5
Merged
Conversation
* all 3 mod files are updated to use RANDOM variables * remove VERBATIM blocks and extra functions/procedures * update HOC files to directly set sequence for RNG variables
12 tasks
nrnhines
approved these changes
Jan 16, 2024
nrnhines
left a comment
There was a problem hiding this comment.
Looks good to me. The RANDOM statement certainly results in pleasing simplifications to the mod file. It seems that VECTOR would be of similar benefit and could follow the same pattern (i.e. vecname could be the first arg to a set of vector_...(vecname, ...) functions. And at the interpreter could associate via mechinst.vecname(HocVector). I suppose a few edge details would have to be worked out)
Contributor
Author
Certainly! It's a very good feeling to write the RNGs in this new way!
Agree! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI_BRANCHES:NMODL_BRANCH=hines/nmodlrandom-simplified,NEURON_BRANCH=hines/nmodlrandom-simplified,