Skip to content
This repository was archived by the owner on Mar 25, 2025. It is now read-only.
This repository was archived by the owner on Mar 25, 2025. It is now read-only.

Move nmodl python files into subdirectory #462

Description

@ohm314

Currently the nmodl python module files are in a top level directory called nmodl. Having the same name as the package itself it often leads to confusion especially when testing the python package. Various scenarios fail because python uses the current working dir as a search dir for modules. This way the local nmodl directory will take precedence over an installed nmodl python module (eg. in site-packages). We have several workarounds to address this, but we keep finding scenarios, where confusing errors show up.
A proper fix is needed. For example the nmodl directory should be moved into another dir, maybe named pkg. It is not sufficient to move the directory as this will entail a number of changes in the build system and CI:

  • CMakeLists.txt need to be checked and fixed
  • setup.py needs to be checked and fixed
  • azure CI will need checking for both the testing and wheel building pipelines
  • travis CI might also need a check

This list is non-exhaustive but should cover most of what is needed.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions