You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently the nmodl python module files are in a top level directory called nmodl. Having the same name as the package itself it often leads to confusion especially when testing the python package. Various scenarios fail because python uses the current working dir as a search dir for modules. This way the local nmodl directory will take precedence over an installed nmodl python module (eg. in site-packages). We have several workarounds to address this, but we keep finding scenarios, where confusing errors show up.
A proper fix is needed. For example the nmodl directory should be moved into another dir, maybe named pkg. It is not sufficient to move the directory as this will entail a number of changes in the build system and CI:
CMakeLists.txt need to be checked and fixed
setup.py needs to be checked and fixed
azure CI will need checking for both the testing and wheel building pipelines
travis CI might also need a check
This list is non-exhaustive but should cover most of what is needed.
Currently the nmodl python module files are in a top level directory called
nmodl. Having the same name as the package itself it often leads to confusion especially when testing the python package. Various scenarios fail because python uses the current working dir as a search dir for modules. This way the localnmodldirectory will take precedence over an installednmodlpython module (eg. insite-packages). We have several workarounds to address this, but we keep finding scenarios, where confusing errors show up.A proper fix is needed. For example the
nmodldirectory should be moved into another dir, maybe namedpkg. It is not sufficient to move the directory as this will entail a number of changes in the build system and CI:This list is non-exhaustive but should cover most of what is needed.