Skip to content
This repository was archived by the owner on Mar 25, 2025. It is now read-only.

fmtlib places files outside of .data when not linking against Python #1153

Description

@JCGoran

When using -DLINK_AGAINST_PYTHON=FALSE (for instance, for building wheels), Eigen and related libs are placed in nmodl/.data, but fmtlib doesn't respect this and stubbornly puts items in other places. Below is an excerpt from the install_manifest.txt file (tested with latest master):

/lib/libfmt.a
/include/fmt/args.h
/include/fmt/chrono.h
/include/fmt/color.h
/include/fmt/compile.h
/include/fmt/core.h
/include/fmt/format.h
/include/fmt/format-inl.h
/include/fmt/os.h
/include/fmt/ostream.h
/include/fmt/printf.h
/include/fmt/ranges.h
/include/fmt/std.h
/include/fmt/xchar.h
/lib/cmake/fmt/fmt-config.cmake
/lib/cmake/fmt/fmt-config-version.cmake
/lib/cmake/fmt/fmt-targets.cmake
/lib/cmake/fmt/fmt-targets-release.cmake
/lib/pkgconfig/fmt.pc
/nmodl/.data/lib/libpywrapper.dylib
/nmodl/_nmodl.cpython-311-darwin.so
/nmodl/.data/include/newton/newton.hpp
/nmodl/.data/include/Eigen/CholmodSupport
/nmodl/.data/include/Eigen/StdVector
/nmodl/.data/include/Eigen/StdDeque
... other files in /nmodl/.data/

I don't know if this is intended or not, but it's somewhat annoying since the wheel built with scikit-build-core (see #1147) has lib (or lib64 on Linux) and include directories along with the nmodl one.

Metadata

Metadata

Assignees

No one assigned

    Labels

    build-systemImproving build systemexternalExternal toolsquestionFurther information is requested

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions