Skip to content
This repository was archived by the owner on Feb 26, 2025. It is now read-only.

Conversation

@alkino
Copy link
Member

@alkino alkino commented Feb 8, 2024

No description provided.

@alkino alkino added the v3 Anything that needs to be resolved before `v3`. label Feb 8, 2024
@alkino alkino force-pushed the cornu/remove_default_ctor_group branch from f73e413 to 088e614 Compare February 8, 2024 16:19
@alkino alkino changed the title Cornu/remove default ctor group Remove default ctor for Group Feb 8, 2024
@alkino alkino changed the title Remove default ctor for Group Remove deprecated default ctor for Group Feb 8, 2024
@codecov
Copy link

codecov bot commented Feb 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7ba4849) 86.13% compared to head (3c43359) 85.84%.
Report is 19 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #948      +/-   ##
==========================================
- Coverage   86.13%   85.84%   -0.30%     
==========================================
  Files          90       89       -1     
  Lines        5858     5657     -201     
==========================================
- Hits         5046     4856     -190     
+ Misses        812      801      -11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

1uc
1uc previously requested changes Feb 9, 2024
Copy link
Collaborator

@1uc 1uc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be discussed :)

@1uc 1uc self-requested a review February 20, 2024 16:04
@1uc 1uc dismissed their stale review February 20, 2024 16:04

resolved

@1uc 1uc merged commit 9a28500 into master Apr 5, 2024
@1uc 1uc deleted the cornu/remove_default_ctor_group branch April 5, 2024 16:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

v3 Anything that needs to be resolved before `v3`.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants