Skip to content
This repository was archived by the owner on Feb 26, 2025. It is now read-only.

Conversation

@1uc
Copy link
Collaborator

@1uc 1uc commented Jan 12, 2024

MPI collective IO, requires that certain HDF5 functions are called collectively. Here some short-circuiting logic for empty datasets interferes when some, but not all, selections from different MPI ranks are empty.

@1uc
Copy link
Collaborator Author

1uc commented Jan 12, 2024

Merge after #913.

@1uc 1uc marked this pull request as ready for review January 12, 2024 13:39
@codecov
Copy link

codecov bot commented Jan 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0d604c8) 85.96% compared to head (e79ddb2) 85.95%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #912      +/-   ##
==========================================
- Coverage   85.96%   85.95%   -0.01%     
==========================================
  Files          89       89              
  Lines        5871     5867       -4     
==========================================
- Hits         5047     5043       -4     
  Misses        824      824              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@pramodk pramodk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@1uc 1uc mentioned this pull request Jan 12, 2024
@1uc 1uc force-pushed the 1uc/fix-non-collective branch from bbc3766 to e79ddb2 Compare January 12, 2024 14:03
@1uc 1uc merged commit fd663cc into master Jan 12, 2024
@1uc 1uc deleted the 1uc/fix-non-collective branch January 12, 2024 15:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants