This repository was archived by the owner on Feb 26, 2025. It is now read-only.
Fix create_datatype<bool>().
#869
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Create the specialization from `create_datatype<bool>` and adds the tests to check that raw arrays of bool are bitwise compatible with the enum that's serialized.
defe171 to
0a3dfa2
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #869 +/- ##
==========================================
+ Coverage 84.75% 84.89% +0.14%
==========================================
Files 70 70
Lines 5056 5090 +34
==========================================
+ Hits 4285 4321 +36
+ Misses 771 769 -2 ☔ View full report in Codecov by Sentry. |
alkino
approved these changes
Nov 27, 2023
Member
alkino
left a comment
There was a problem hiding this comment.
Of course, I missed it when I added boolean
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create the specialization from
create_datatype<bool>and adds the tests to check that raw arrays of bool are bitwise compatible with the enum that's serialized.