This repository was archived by the owner on Feb 26, 2025. It is now read-only.
Add access to values of properties #684
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
764fad5 to
c599963
Compare
Member
Author
|
I wonder if we should return tuple instead of having one getter for each value. Should we do a static function instead? static std::tuple<hsize_t, hsize_t> fromDataTransferProps(dxpl); |
c599963 to
eae2197
Compare
Codecov Report
@@ Coverage Diff @@
## master #684 +/- ##
==========================================
+ Coverage 80.28% 80.35% +0.07%
==========================================
Files 68 68
Lines 4113 4123 +10
==========================================
+ Hits 3302 3313 +11
+ Misses 811 810 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
eae2197 to
76a812e
Compare
b59226d to
c2b2583
Compare
matz-e
reviewed
Feb 6, 2023
Member
matz-e
left a comment
There was a problem hiding this comment.
I think it looks pretty clean. The only place I'd return a pair is for the version bounds.
And we don't have too many other free functions, do we? So your current API seems fine to me.
alkino
commented
Feb 8, 2023
1uc
approved these changes
Feb 10, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
API can be discussed