Skip to content
This repository was archived by the owner on Mar 20, 2023. It is now read-only.

GitLab CI improvements (also testing NEURON C++)#770

Merged
olupton merged 8 commits into
masterfrom
olupton/test-neuron-c++
Feb 3, 2022
Merged

GitLab CI improvements (also testing NEURON C++)#770
olupton merged 8 commits into
masterfrom
olupton/test-neuron-c++

Conversation

@olupton

@olupton olupton commented Feb 2, 2022

Copy link
Copy Markdown
Contributor

Description
Simplify GitLab CI configuration following upstream changes to hpc/gitlab-helpers and BlueBrain/spack#1468.

  • it is now more convenient to trigger CoreNEURON's pipeline manually, with NEURON_BRANCH and NMODL_BRANCH optionally set
  • we no longer rely on (the default) CI_BRANCHES:NEURON_BRANCH=master to make the SimulationStack child pipeline build neuron@develop instead of neuron

This PR is also serving as a way of testing the NEURON C++ changes in neuronsimulator/nrn#1597 in the CoreNEURON CI, but that is not relevant to the actual changeset in CoreNEURON.

Use certain branches for the SimulationStack CI
CI_BRANCHES:NEURON_BRANCH=olupton/more-c++,SPACK_BRANCH=olupton/test-neuron-c++

@olupton olupton changed the title dummy change Test NEURON C++ changes Feb 2, 2022
@olupton olupton closed this Feb 2, 2022
@olupton olupton reopened this Feb 2, 2022
@olupton olupton closed this Feb 2, 2022
@olupton olupton reopened this Feb 2, 2022
@olupton olupton closed this Feb 2, 2022
@olupton olupton reopened this Feb 2, 2022
@olupton olupton closed this Feb 2, 2022
@olupton olupton reopened this Feb 2, 2022
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

Merging #770 (9f0881c) into master (572965b) will not change coverage.
The diff coverage is n/a.

❗ Current head 9f0881c differs from pull request most recent head aaa73c7. Consider uploading reports for the commit aaa73c7 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master     #770   +/-   ##
=======================================
  Coverage   56.00%   56.00%           
=======================================
  Files         108      108           
  Lines        8994     8994           
=======================================
  Hits         5037     5037           
  Misses       3957     3957           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 572965b...aaa73c7. Read the comment docs.

@olupton olupton closed this Feb 2, 2022
@olupton olupton reopened this Feb 2, 2022
@olupton olupton closed this Feb 2, 2022
@olupton olupton reopened this Feb 2, 2022
@olupton olupton closed this Feb 2, 2022
@olupton olupton reopened this Feb 2, 2022
@olupton olupton closed this Feb 3, 2022
@olupton olupton reopened this Feb 3, 2022
@olupton olupton changed the title Test NEURON C++ changes GitLab CI improvements (also testing NEURON C++) Feb 3, 2022
@olupton olupton marked this pull request as ready for review February 3, 2022 13:15
@olupton olupton merged commit fa24f3e into master Feb 3, 2022
@olupton olupton deleted the olupton/test-neuron-c++ branch February 3, 2022 16:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants