This repository was archived by the owner on Jan 2, 2025. It is now read-only.
add repo sync analytics #1122
Merged
add repo sync analytics #1122
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tracks repo metadata on first index, or on full reindex (when the
tantivy index hash is updated, for example), includes the following
info:
- repo ref
- repo provider
- size in bytes
- number of qdrant chunks
- time taken to index
sample event:
RepoEvent {
name: "index",
payload: [
("repo_ref", String("nerdypepper/dijo")),
("provider", String("github")),
("file_count", Number(35)),
("chunk_count", Number(236)),
("bytes", String("116.59KB")),
("sync_time", String("4.957807429s")),
],
}
---
to test this changeset, set the following values in `local_config.json`:
{
"analytics_key": "..",
"analytics_data_plane": ".."
}
run rudderstack in "live event stream" mode, and index a repository.
- marks full index resets as `SchemaUpgrade`s - marks periodic reindex jobs as `PeriodicSync`s
oppiliappan
commented
Nov 13, 2023
rsdy
reviewed
Nov 14, 2023
Contributor
rsdy
left a comment
There was a problem hiding this comment.
The fact that this patch is interwoven with the indexing logic so much makes it slightly difficult to track. I'd prefer containing this logic a bit more, and preferably separating it out to another module from file as much as we can.
rsdy
approved these changes
Nov 14, 2023
Contributor
rsdy
left a comment
There was a problem hiding this comment.
This looks a lot cleaner. Thanks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tracks repo metadata on first index, or on full reindex (when the tantivy index hash is updated, for example), includes the following info:
sample event:
to test this changeset, set the following values in
local_config.json:run rudderstack in "live event stream" mode, and index a repository.