Merged
Conversation
…#40927 Add type for KafkaConsumer.createReadStream Fix return type for Producer.createWriteStream
codeburke
reviewed
Jan 23, 2020
Collaborator
codeburke
left a comment
There was a problem hiding this comment.
I'm not a Typescript expert, but would the EventEmitter change cause any issues with different versions of Node?
Contributor
Author
|
Maybe yes if implementation is fully on Typescript. But this is only definitions for type checking at compile time. Now compilation of Typescript project is broken due to changes in |
Collaborator
|
The issue happens with |
Contributor
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Package wont be able to compile with ts due to changes in DefinitelyTyped/DefinitelyTyped#40927
Up version after merge pls. This is very critical.
Fix error with EventEmitter caused by DefinitelyTyped/DefinitelyTyped#40927
Add type for KafkaConsumer.createReadStream
Fix return type for Producer.createWriteStream