Delete socket file when server isn't running#10
Merged
BlakeWilliams merged 2 commits intomainfrom Apr 14, 2022
Merged
Conversation
Sometimes the server dies without removing the socket file. When this happens the server will fail to start even though there is no running server. Instead of failing immediately, the server command now attempts to talk to the server running on the socket. If it succeeds, it exits since a server is already running. If it fails, it removes the socket file and starts the server.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sometimes the server dies without removing the socket file. When this
happens the server will fail to start even though there is no running
server.
Instead of failing immediately, the server command now attempts to talk
to the server running on the socket. If it succeeds, it exits since a
server is already running. If it fails, it removes the socket file and
starts the server.