Capture XML namepace prefix and URL within the deserialized data#89
Merged
Blacksmoke16 merged 9 commits intomasterfrom Aug 15, 2021
Merged
Capture XML namepace prefix and URL within the deserialized data#89Blacksmoke16 merged 9 commits intomasterfrom
Blacksmoke16 merged 9 commits intomasterfrom
Conversation
da74b2d to
c7e2872
Compare
Handle nodes with multiple namespaces Handle unprefixed namespaces Take element prefixes into consideration processing child nodes Monkey patch in `#namespace_definitions` Can be replaced upstream after crystal-lang/crystal#11037 is resolved/released Add optional ability to parse XML namespaces This better supports XML structures with namespaces/prefixed elements but is opt in as it changes the structure of the JSON. This will become the default in oq 2.x
Removes reliance on parsing a `NamedTuple` directly Removes need to have `**args` on every conversion method
fbe8257 to
9eb667f
Compare
Owner
Author
|
@LoganBarnett I added specs and error if someone uses the namespace option w/o |
Contributor
|
@Blacksmoke16 whoops, I commented back on the issue. Gist: Looks good! Let's merge it :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #85