Skip to content

Default value for crypto_list to add and increase priority of stablecoins #82

@njwedwards

Description

@njwedwards

I noticed this after checking my calculation and noticing that I had a large loss that was incurred on BUSD when traded against XRP, however in reality the loss was from XRP which had lost value. This was due to the setup of crypto_list.

I believe that stablecoins should be added as the highest priority coins.

The current setup:

crypto_list: ['BTC', 'ETH', 'XRP', 'LTC', 'BCH', 'USDT']

My new setup (which could be a sensible default):

crypto_list: ['USDT', 'BUSD', 'USDC', 'BTC', 'ETH', 'XRP', 'LTC', 'BCH']

After this change the calculations seem correct with losses and profits being in the right place, with my stablecoin holdings not showing wild losses (or gains), just the change from GBP.

I think it would also be good to add an explanatory note to [https://github.com/BittyTax/BittyTax#crypto_list] particularly as others may use less well known stablecoins etc.

Metadata

Metadata

Assignees

Labels

enhancementNew feature or request

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions